Issue244

Title Any User can hijack other Users' Queries
Priority bug Status resolved
Superseder Nosy List ajaksu2, loewis
Assigned To Topics

Created on 2009-02-25.22:00:59 by ajaksu2, last changed 2009-04-06.04:03:20 by ajaksu2.

Files
File name Uploaded Type Edit Remove
_generic_index_query.diff ajaksu2, 2009-02-25.22:10:47 text/plain
actions_query.diff ajaksu2, 2009-02-25.22:00:59 text/x-diff
avoid_editcsv.diff ajaksu2, 2009-03-08.12:33:01 text/x-diff
Messages
msg1303 (view) Author: ajaksu2 Date: 2009-04-06.04:03:20
I don't think so, cannot trigger it anymore. I'll reopen it or a new one if I
find otherwise.
msg1266 (view) Author: loewis Date: 2009-03-21.19:25:25
Is this still an issue after the roundup update?
msg1230 (view) Author: loewis Date: 2009-03-08.13:47:31
I have now disabled editcsv for roundup.

I do think it is useful, as various coordinators use it to add components etc.
Of course, we could also create forms for it, or have people submit such
requests to this tracker, so I create the components through the command line -
however, the CSV interface is really convenient for distributed administration.
msg1227 (view) Author: ajaksu2 Date: 2009-03-08.12:33:01
We could either ditch EditCSVAction entirely or add permission checks to it, if
it's an useful action. To solve this class of problems, I think it'd be
necessary to add another kind of permission ('EditCSV') to Roles and check for that.

Here's a temporary fix, given the potential hassle described in private email.
msg1218 (view) Author: loewis Date: 2009-03-08.09:00:34
actions_query.diff is not appropriate to solve this problem: it puts knowledge
of a "keywords" class into roundup.

I don't quite understand the problem. If it is possible to edit arbitrary
queries through CSV, why is it not possible to edit arbitrary issues through CSV?

(I'm assuming it is not possible to edit arbitrary issues - if it was, we are in
much bigger problems)
msg1192 (view) Author: ajaksu2 Date: 2009-02-25.22:10:47
And this one removes the UI :)

I think 'keyword' (implying 'Developer') might not be strict enough...
msg1191 (view) Author: ajaksu2 Date: 2009-02-25.22:00:58
Any User has the ability to edit or create Queries, which equates to Admin's
ability to edit Classes, as far as Queries are concerned. This ignores Query
ownership in the CSV interface, allowing one to edit, steal or delete someone
else's Queries.

Attached patch blocks this path.
History
Date User Action Args
2009-04-06 04:03:20ajaksu2setstatus: chatting -> resolved
messages: + msg1303
2009-03-21 19:25:26loewissetmessages: + msg1266
2009-03-08 13:47:31loewissetpriority: critical -> bug
messages: + msg1230
2009-03-08 12:33:02ajaksu2setpriority: urgent -> critical
files: + avoid_editcsv.diff
messages: + msg1227
2009-03-08 09:00:35loewissetnosy: + loewis
messages: + msg1218
2009-02-25 22:10:47ajaksu2setfiles: + _generic_index_query.diff
status: unread -> chatting
messages: + msg1192
2009-02-25 22:00:59ajaksu2create