Issue247

Title Add Rietveld Issue link
Priority feature Status chatting
Superseder Nosy List ajaksu2, loewis
Assigned To Topics

Created on 2009-03-06.02:14:55 by ajaksu2, last changed 2009-03-10.16:47:12 by ajaksu2.

Files
File name Uploaded Type Edit Remove
getissue.py ajaksu2, 2009-03-06.14:07:56 text/plain
reviewauditor.py ajaksu2, 2009-03-06.15:33:10 text/plain
rietveld.diff ajaksu2, 2009-03-06.02:14:54 text/plain
upload.py ajaksu2, 2009-03-10.16:45:17 text/x-python
Messages
msg1237 (view) Author: ajaksu2 Date: 2009-03-10.16:45:17
It seems that setting the debug level to info avoids the inlining of the patch.
I'm mailing codereview-discuss to make sure :)

So far, the workflow for a new issue would be:
1 - Create a Roundup issue (RoI)
2 - Use the modified upload.py to create a Rietveld issue (RiI) that has a
reference to RoI in the subject. This adds a link to RoI at RiI. Uploading the
patch to RoI should be possible.
3 - The auditor creates a link in RoI to RiI

Any suggestions on this?

Before we add this, I'd like to have this workflow available:
1 - Using the modified upload.py, set a description and ask it to create a new
Roundup issue.
2 - It creates the issue and adds the patch
3 - Start at 2 in the above workflow :)

I have a script that does the 'create a new Roundup issue from command line'
working, just have to spend some time adding the bits to upload.py or a wrapper.
msg1221 (view) Author: loewis Date: 2009-03-08.09:20:39
Is it possible to have Rietveld not include the entire patch in the message, or
send it as an attachment? Or could we strip it out?
msg1220 (view) Author: loewis Date: 2009-03-08.09:17:17
With reviewauditor.py, what would the workflow look like for creating a tracker
issue with associated rietveld issue?
msg1213 (view) Author: ajaksu2 Date: 2009-03-06.15:33:10
Here's a detector that updates Rietveld ID when a message contents match
r'http://codereview.appspot.com/(\d+)'.

It defeats the rietveld_id restriction of Users. We could either lift that
restriction or enforce it in the detector, whatever makes more sense.
msg1212 (view) Author: ajaksu2 Date: 2009-03-06.14:18:22
upload.py with Python Tracker (PT) issue fetched hacked in.

Allows fetching a PT issue title to set Rietveld issue subject (--message).
Fetches PT file description or message content to set Rietveld issue description
(--description). Adds PT's email to CC list (--cc).

I think a link from Rietveld issue to PT issue is a must have, adding the
command line could be nice too.

We could also add an option to set any PT issue Rietveld ID on successful code
review issue creation (would require asking for PT user email).

See the following issues for examples:
http://bugs.python.org/issue400608
http://bugs.python.org/issue2771
http://codereview.appspot.com/25073
http://codereview.appspot.com/24075
msg1211 (view) Author: ajaksu2 Date: 2009-03-06.14:07:56
A better implementation of fetching info from the Python tracker.
msg1210 (view) Author: ajaksu2 Date: 2009-03-06.02:14:54
This adds a Rietveld Issue field that is hidden for Anonymous/Users when not set
and allows editing by Developers.
History
Date User Action Args
2009-03-10 16:47:12ajaksu2setfiles: - upload.py
2009-03-10 16:45:18ajaksu2setfiles: + upload.py
messages: + msg1237
2009-03-08 09:20:39loewissetmessages: + msg1221
2009-03-08 09:17:17loewissetnosy: + loewis
messages: + msg1220
2009-03-06 15:33:10ajaksu2setfiles: + reviewauditor.py
messages: + msg1213
2009-03-06 14:18:23ajaksu2setfiles: + upload.py
messages: + msg1212
2009-03-06 14:07:57ajaksu2setfiles: + getissue.py
status: unread -> chatting
messages: + msg1211
2009-03-06 02:14:55ajaksu2create