Issue254

Title Roundup treats <URL> badly
Priority bug Status resolved
Superseder Nosy List amk, ezio.melotti, loewis, montanaro
Assigned To ezio.melotti Topics

Created on 2009-03-26.03:30:26 by montanaro, last changed 2010-08-12.07:08:37 by ezio.melotti.

Messages
msg1783 (view) Author: ezio.melotti Date: 2010-08-12.07:08:36
Fixed in r83955.
Patch contributed upstream in http://issues.roundup-tracker.org/issue2550664.
msg1779 (view) Author: ezio.melotti Date: 2010-08-10.18:22:15
As pointed out by MVL the URLs are broken only when something (e.g. a '.') follows the >, so "<http://bugs.python.org/setuptools/issue63>" is linkified correctly but "<http://bugs.python.org/setuptools/issue63>." is not.
msg1778 (view) Author: loewis Date: 2010-08-10.18:10:21
Let's see how this get linked

<http://bugs.python.org/setuptools/issue63>
msg1754 (view) Author: ezio.melotti Date: 2010-08-01.02:21:31
Martin, unless we figure out why here the > is included in the URL, we should probably close this.
msg1719 (view) Author: ezio.melotti Date: 2010-07-04.02:26:23
I fixed the ')' in r82525, using some heuristic to determine if the ')' is part of the URL or not (if you want to try breaking it you are welcome).
Regarding the '>' I think it might depend on the version of Roundup used for this tracker and the Jython one. Is it the same version that we use for python-dev?
In recent versions of Roundup the regex for matching URLs has been improved.
msg1697 (view) Author: ezio.melotti Date: 2010-06-27.10:04:31
That's not a problem, it's easy to allow ')' inside the URL but not at the end. Some Wikipedia links also use ')' at the end (e.g. http://en.wikipedia.org/wiki/Python_(programming_language)), but I think it's more common to have links enclosed in () than links that contain and end with a ')' (however I think it might still be possible to distinguish between URLs enclosed in () and URLs that end with ')').

On a side note, on my instance of the tracker the '>' is not included in the link, let's see if here it is: <http://bugs.python.org/setuptools/issue63>.
msg1695 (view) Author: loewis Date: 2010-06-27.06:48:19
I disagree: ')' can be, and actually is, part of the URL. For example, Microsoft hosts URLs like

http://msdn.microsoft.com/en-us/library/ms741540(VS.85).aspx
msg1693 (view) Author: ezio.melotti Date: 2010-06-26.23:46:30
This problem exists with ')' too.
msg1276 (view) Author: montanaro Date: 2009-03-26.03:30:26
Take a look at this setuptools issue:

  http://bugs.python.org/setuptools/issue63

When I first posted it I embedded a Google Code tracker URL in <...>.  Roundup
should almost certainly treat literal '<' and '>' as not part of URLs.  It
encoded the trailing '>' and generated a bogus URL.
History
Date User Action Args
2010-08-12 07:08:37ezio.melottisetstatus: chatting -> resolved
messages: + msg1783
2010-08-10 18:22:15ezio.melottisetmessages: + msg1779
2010-08-10 18:10:21loewissetmessages: + msg1778
2010-08-01 02:21:31ezio.melottisetmessages: + msg1754
2010-07-04 02:26:24ezio.melottisetnosy: + amk
messages: + msg1719
2010-06-27 10:04:31ezio.melottisetmessages: + msg1697
2010-06-27 06:48:20loewissetnosy: + loewis
messages: + msg1695
2010-06-26 23:46:30ezio.melottisetstatus: unread -> chatting
assignedto: ezio.melotti
messages: + msg1693
nosy: + ezio.melotti
2009-03-26 03:30:27montanarocreate