Issue264

Title Mail gateway borks quotes and console sessions
Priority bug Status chatting
Superseder Nosy List ajaksu2
Assigned To Topics

Created on 2009-04-07.16:48:11 by ajaksu2, last changed 2009-04-07.17:29:38 by ajaksu2.

Files
File name Uploaded Type Edit Remove
fix_quotes.diff ajaksu2, 2009-04-07.17:29:26 text/x-diff
pc.py ajaksu2, 2009-04-07.16:48:10 text/x-python
Messages
msg1309 (view) Author: ajaksu2 Date: 2009-04-07.17:29:26
In the original code, a for-else is used with wrong logic, so that if there was
a response ('no blank line between quoted message and response') in the section,
the loop would break and not execute the else[1]. Unfortunately, the code that
checks whether to include the quoted text verbatim is inside the else clause.

Attached patch fixes this and reorganizes the code a bit.

[1] http://docs.python.org/reference/compound_stmts.html#the-for-statement
msg1308 (view) Author: ajaksu2 Date: 2009-04-07.16:50:37
This patch fixes the symptom, I'll try to find the cause and fix it. This will
probably lead to a lot more noise reaching the tracker if committed as-is.
msg1307 (view) Author: ajaksu2 Date: 2009-04-07.16:48:10
Antoine Pitrou reported the issue that Roundup borks email responses containing
lines stating with '>' [1][2][3]. I've tracked it down to mailgw.parseContent
wrongly discarding sections bits.

Attached script shows this behavior.

[1] http://bugs.python.org/msg82084
[2] http://bugs.python.org/msg85439
[3] http://bugs.python.org/msg70718

Antoine Pitrou wrote:
The problem I'm having often is that quoted text, or snippets of interpreter
sessions, are lost. Basically, everything which begins with one or more '>'
signs is threatened.
History
Date User Action Args
2009-04-07 17:29:38ajaksu2setfiles: - quotes_interactive.diff
2009-04-07 17:29:27ajaksu2setfiles: + fix_quotes.diff
messages: + msg1309
2009-04-07 16:50:37ajaksu2setfiles: + quotes_interactive.diff
status: unread -> chatting
messages: + msg1308
2009-04-07 16:48:11ajaksu2create