Issue414

Title Mercurial integration: verify repo when adding
Priority bug Status chatting
Superseder Nosy List eric.araujo, ezio.melotti, loewis
Assigned To Topics

Created on 2011-08-06.14:52:13 by eric.araujo, last changed 2012-09-01.17:23:36 by ezio.melotti.

Messages
msg2206 (view) Author: eric.araujo Date: 2011-08-06.14:52:13
It has happened more than one time that people put an ssh or private https URI in the remote repo field, which makes Roundup error when someone wants to create a patch.  If possible, access should be checked when a repo is added.

(FTR, the Bitbucket https URIs are not private, this may be yet another bug.)
msg2580 (view) Author: ezio.melotti Date: 2012-09-01.17:23:35
> (FTR, the Bitbucket https URIs are not private, this may be yet another bug.)

This should be fixed with ebed4eccab36.

The error reported by the tracker was "('invalid token', 90)", and was caused by:

>>> old = 'max(ancestors(branch("%s")))-outgoing("%s"))' % (patchbranch, base)
>>> commands.diff(repo.ui, repo, rev=[old, patchbranch])
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/usr/lib/python2.7/dist-packages/mercurial/commands.py", line 2319, in diff
    node1, node2 = scmutil.revpair(repo, revs)
  File "/usr/lib/python2.7/dist-packages/mercurial/scmutil.py", line 497, in revpair
    l = revrange(repo, revs)
  File "/usr/lib/python2.7/dist-packages/mercurial/scmutil.py", line 549, in revrange
    m = revset.match(repo.ui, spec)
  File "/usr/lib/python2.7/dist-packages/mercurial/revset.py", line 1046, in match
    raise error.ParseError(_("invalid token"), pos)
mercurial.error.ParseError: ('invalid token', 90)

The problem was an extra ')', and http://mail.python.org/pipermail/python-dev/2011-November/114704.html told me which one had to be removed.  Bitbucket remote repos should now work.
History
Date User Action Args
2012-09-01 17:23:36ezio.melottisetstatus: unread -> chatting
nosy: + ezio.melotti
messages: + msg2580
2011-08-06 14:52:13eric.araujocreate