Issue424

Title Rietveld: AssertionError when trying to reply to comments
Priority bug Status chatting
Superseder Nosy List nadeem.vawda, skrah
Assigned To Topics

Created on 2011-10-11.10:13:20 by nadeem.vawda, last changed 2011-12-05.14:14:13 by skrah.

Messages
msg2274 (view) Author: nadeem.vawda Date: 2011-10-11.10:13:20
I am not able to reply to some comments on Rietveld. When I tried to reply to
the comments by loewis at http://bugs.python.org/review/6715/diff/3335/10393, I
get an error saying "Error: AssertionError; please report!". This takes the form
of red text replacing the comment I was replying to, and appears after I enter
my reply and hit "Save".

This does not happen if I first try to enter a reply to one of the previous
batch of comments (by amaury.forgeotdarc) first, discard it, and then reply to
one of loewis's comments.

This may be related to issue 402 - I am still not able to sign in to Rietveld
without temporarily changing my username.
msg2338 (view) Author: skrah Date: 2011-12-04.14:27:13
I'm constantly getting this error:

Environment:

Request Method: GET
Request URL: http://bugs.python.org/review/7652/show
Django Version: 1.1.1 SVN-17159
Python Version: 2.5.2
Installed Applications:
['django.contrib.auth',
 'django.contrib.contenttypes',
 'django.contrib.sessions',
 'django.contrib.sites',
 'django.contrib.admin',
 'gae2django',
 'rietveld_helper',
 'codereview']
Installed Middleware:
('django.middleware.common.CommonMiddleware',
 'django.contrib.sessions.middleware.SessionMiddleware',
 'django.contrib.auth.middleware.AuthenticationMiddleware',
 'roundup_helper.middleware.LookupRoundupUser',
 'gae2django.middleware.FixRequestUserMiddleware',
 'rietveld_helper.middleware.AddUserToRequestMiddleware',
 'django.middleware.doc.XViewMiddleware')


Traceback:
File "/home/roundup/trackers/tracker/rietveld/django/core/handlers/base.py" in get_response
  88.                 response = middleware_method(request, callback, callback_args, callback_kwargs)
File "/home/roundup/trackers/tracker/rietveld/rietveld_helper/middleware.py" in process_view
  21.         response = view_func(request, *view_args, **view_kwargs)
File "/home/roundup/trackers/tracker/rietveld/codereview/views.py" in issue_wrapper
  643.     return func(request, *args, **kwds)
File "/home/roundup/trackers/tracker/rietveld/codereview/views.py" in show
  1493.                   'has_draft_message': has_draft_message,
File "/home/roundup/trackers/tracker/rietveld/codereview/views.py" in respond
  416.     must_choose_nickname = not account.user_has_selected_nickname()

Exception Type: AttributeError at /review/7652/show
Exception Value: 'NoneType' object has no attribute 'user_has_selected_nickname'


Does that look like the same issue or should I open another one?
msg2340 (view) Author: nadeem.vawda Date: 2011-12-04.21:14:28
Nope, that looks like a different error. The one I was getting was an AssertionError,
not an AttributeError.
msg2342 (view) Author: skrah Date: 2011-12-05.14:14:13
Nadeem Vawda <metatracker@psf.upfronthosting.co.za> wrote:
> Nope, that looks like a different error. The one I was getting was an AssertionError,
> not an AttributeError.

Thanks, I'll open another one.
History
Date User Action Args
2011-12-05 14:14:13skrahsetmessages: + msg2342
2011-12-04 21:14:28nadeem.vawdasetmessages: + msg2340
2011-12-04 14:27:13skrahsetstatus: unread -> chatting
nosy: + skrah
messages: + msg2338
2011-10-11 10:13:20nadeem.vawdacreate