Issue437

Title Ignore a dot in urls if it's the last character
Priority bug Status resolved
Superseder Nosy List ambv, ezio.melotti, ralph.corderoy, tshepang
Assigned To ezio.melotti Topics

Created on 2012-03-05.12:44:28 by tshepang, last changed 2012-07-29.04:31:15 by ezio.melotti.

Files
File name Uploaded Type Edit Remove
issue437.diff ezio.melotti, 2012-05-09.11:13:33 text/plain
Messages
msg2388 (view) Author: tshepang Date: 2012-03-05.12:44:28
When commit url ends with a dot (e.g. http://bugs.python.org/msg152756), Roundup thinks the dot is part of the url, so it's often like a broken link:

good: http://hg.python.org/cpython/file/567767a6df02/Lib/packaging/tests/test_version.py#l68
bad: http://hg.python.org/cpython/file/567767a6df02/Lib/packaging/tests/test_version.py#l68.
msg2389 (view) Author: ezio.melotti Date: 2012-03-05.12:54:08
This should be fixed already (unless I'm missing something), but for some reason it doesn't seem to work.  I'll check again and see if there is indeed a bug with the code or is there another reason for this.
msg2465 (view) Author: ezio.melotti Date: 2012-04-17.04:51:46
I was pretty sure I fixed this already, but I tried on a local instance on my laptop and it's not working, so I'm probably just confusing this problem with <http://issues.roundup-tracker.org/issue2550657>.  The fact that I can't find any tests for it around seems to confirm this (or maybe I have local changes on my home pc since iirc it's working there).
Once I get home I'll double check this and then fix it.
msg2485 (view) Author: ezio.melotti Date: 2012-05-09.11:13:33
Eventually I got home and checked, and it's failing here too.
The attached patch fixes the issue, ignoring a single trailing dot, comma, colon, semicolon, or exclamation mark.  Maybe the question mark could be added too; closing parentheses are already ignored.
I tested the patch locally and it seems to work fine, however this should be reported and fixed upstream.  I'll create a new issue upstream once I prepare a proper patch with tests.
msg2563 (view) Author: ezio.melotti Date: 2012-07-29.04:31:15
The upstream issue (http://issues.roundup-tracker.org/issue2550759) has been fixed and I updated our tracker instance to include the fix.
History
Date User Action Args
2012-07-29 04:31:15ezio.melottisetstatus: chatting -> resolved
messages: + msg2563
2012-05-25 12:38:44ralph.corderoysetnosy: + ralph.corderoy
2012-05-09 11:13:33ezio.melottisetfiles: + issue437.diff
nosy: + ambv
messages: + msg2485
2012-04-17 04:51:46ezio.melottisetassignedto: ezio.melotti
messages: + msg2465
2012-03-05 12:54:09ezio.melottisetstatus: unread -> chatting
nosy: + ezio.melotti
messages: + msg2389
2012-03-05 12:44:28tshepangcreate