Issue490

Title Review links crash after changing username
Priority bug Status resolved
Superseder Nosy List berker.peksag, heikki.partanen
Assigned To Topics

Created on 2012-11-05.19:11:25 by heikki.partanen, last changed 2018-06-12.18:28:14 by berker.peksag.

Files
File name Uploaded Type Edit Remove
username_change_crashes_rietfeld.patch heikki.partanen, 2012-11-05.19:11:24 text/plain
Messages
msg2628 (view) Author: heikki.partanen Date: 2012-11-05.19:11:24
Crash in roundup_helper/middleware.py

1. Open an issue review (bugs.python.org/review#####) link in one browser, session gets created
2. Log into your account with another browser, edit your account, change username into something else
3. Open again the issue review link in the old browser that has the session with old username

As the old session has the wrong username, it crashes on this line as no user is found with the old username:
roundup_user = User.objects.filter(_username=username)[0]
msg3488 (view) Author: berker.peksag Date: 2018-06-12.18:28:14
Thanks for the report and for the patch.

The recommended way of contributing to Python is now GitHub pull requests and we no longer maintain our Rietveld instance.

Closing this issue.
History
Date User Action Args
2018-06-12 18:28:14berker.peksagsetstatus: unread -> resolved
nosy: + berker.peksag
messages: + msg3488
2012-11-05 19:11:25heikki.partanencreate