Issue517

Title Issue Tracker crashes when replying to patch review
Priority bug Status chatting
Superseder Nosy List ezio.melotti, jasujm, stevenjd
Assigned To Topics

Created on 2013-05-15.10:42:19 by jasujm, last changed 2013-08-19.02:40:16 by stevenjd.

Messages
msg2734 (view) Author: jasujm Date: 2013-05-15.10:42:18
I tried to reply to a patch review, more specifically this one: http://bugs.python.org/review/17976/#ps8158

The tracker crashed, giving me the following traceback:

Environment:

Request Method: POST
Request URL: http://bugs.python.org/review/17976/publish
Django Version: 1.2.3
Python Version: 2.6.6
Installed Applications:
['django.contrib.auth',
 'django.contrib.contenttypes',
 'django.contrib.sessions',
 'django.contrib.sites',
 'django.contrib.admin',
 'gae2django',
 'rietveld_helper',
 'codereview']
Installed Middleware:
('django.middleware.common.CommonMiddleware',
 'django.contrib.sessions.middleware.SessionMiddleware',
 'django.contrib.auth.middleware.AuthenticationMiddleware',
 'roundup_helper.middleware.LookupRoundupUser',
 'gae2django.middleware.FixRequestUserMiddleware',
 'rietveld_helper.middleware.DisableCSRFMiddleware',
 'rietveld_helper.middleware.AddUserToRequestMiddleware',
 'django.middleware.doc.XViewMiddleware')


Traceback:
File "/usr/lib/pymodules/python2.6/django/core/handlers/base.py" in get_response
  95.                     response = middleware_method(request, callback, callback_args, callback_kwargs)
File "/home/roundup/trackers/tracker/rietveld/rietveld_helper/middleware.py" in process_view
  37.         response = view_func(request, *view_args, **view_kwargs)
File "/home/roundup/trackers/tracker/rietveld/codereview/views.py" in login_wrapper
  657.     return func(request, *args, **kwds)
File "/home/roundup/trackers/tracker/rietveld/codereview/views.py" in issue_wrapper
  741.     return func(request, *args, **kwds)
File "/home/roundup/trackers/tracker/rietveld/codereview/views.py" in xsrf_wrapper
  694.     return func(request, *args, **kwds)
File "/home/roundup/trackers/tracker/rietveld/codereview/views.py" in publish
  3053.                       in_reply_to=form.cleaned_data.get('in_reply_to'))
File "/home/roundup/trackers/tracker/rietveld/codereview/views.py" in _make_message
  3223.       replied_issue_id = msg.in_reply_to.issue.key().id()

Exception Type: AttributeError at /review/17976/publish
Exception Value: 'NoneType' object has no attribute 'issue'

I repeated twice, always giving the same result.
msg2765 (view) Author: stevenjd Date: 2013-08-17.16:37:36
I am getting the same error on multiple reviews, including:

http://bugs.python.org/review/18606/#msg1

Traceback is the same as reported by jasujm.
msg2766 (view) Author: ezio.melotti Date: 2013-08-17.17:43:38
Did you do the login on Roundup first?
What do you see on the top right of the rietveld page?
If you are logged in you should see your email address followed by your username (and possibly followed by a red message that suggests you to choose your nickname that you can ignore).
msg2767 (view) Author: stevenjd Date: 2013-08-18.02:15:29
On 18/08/13 03:43, Ezio Melotti wrote:
>
> Did you do the login on Roundup first?
> What do you see on the top right of the rietveld page?
> If you are logged in you should see your email address followed by your username (and possibly followed by a red message that suggests you to choose your nickname that you can ignore).

Yes, I am logged in. I see:

Rietveld Code Review Tool
<email> (stevenjd) | Please choose your nickname with ...
msg2768 (view) Author: ezio.melotti Date: 2013-08-18.15:21:28
When are you getting the error exactly?
While accessing the diff pages? While trying to add inline comments? While submitting the review?
Have you tried refreshing the page and sending the data again when it failed?
Can you try to leave some review on issue 2771 (the test issue) to see if it works there?
msg2769 (view) Author: stevenjd Date: 2013-08-19.02:40:15
On 19/08/13 01:21, Ezio Melotti wrote:
>
> Ezio Melotti added the comment:
>
> When are you getting the error exactly?
> While accessing the diff pages? While trying to add inline comments? While submitting the review?

I click the "Reply" link at the base of a message, and a text box appears. I type in the text box, and click "Send Message", and I get AttributeError at /review/18606/publish.

> Have you tried refreshing the page and sending the data again when it failed?

If I refresh the page, I get the same AttributeError crash report.

If I click my browser's Back button, it returns to the review page, but the text box is gone.

> Can you try to leave some review on issue 2771 (the test issue) to see if it works there?

Okay, I went to this URL:

http://bugs.python.org/review/2771/#ps5923

and replied to the most recent message from cjerdonek, and it succeeded.

I navigated to the original issue 18606 (i.e. not using the Back button) and tried replying to a message again, and again it failed.
History
Date User Action Args
2013-08-19 02:40:16stevenjdsetmessages: + msg2769
2013-08-18 15:21:28ezio.melottisetmessages: + msg2768
2013-08-18 02:15:29stevenjdsetmessages: + msg2767
2013-08-17 17:43:38ezio.melottisetnosy: + ezio.melotti
messages: + msg2766
2013-08-17 16:37:37stevenjdsetstatus: unread -> chatting
nosy: + stevenjd
messages: + msg2765
2013-05-15 10:42:19jasujmcreate