Title Only link PR to the bpo that is in the PR title, not the body
Priority bug Status chatting
Superseder Nosy List Mariatta, berker.peksag, ezio.melotti, maciej.szulik, r.david.murray
Assigned To Topics

Created on 2017-06-10.02:10:29 by Mariatta, last changed 2017-11-09.20:06:05 by berker.peksag.

msg3361 (view) Author: Mariatta Date: 2017-06-10.02:10:28
Regarding this PR:

It has  bpo-30266 in the title, where the PR should be linked to.
But the PR body mentions another bpo number (bpo-25958), as a result this PR is also linked to bpo-25958. This PR should only be linked to bpo-30266.

When linking bpo and GitHub PR I think it should only look at the PR title, and not the body.
msg3362 (view) Author: Mariatta Date: 2017-06-10.02:12:11
FYI I just unlinked the PR from bpo-25958
msg3387 (view) Author: ezio.melotti Date: 2017-09-08.00:30:28
Maciej, didn't we fix this?
msg3388 (view) Author: ezio.melotti Date: 2017-09-08.01:08:17
Actually we just limited the number of issues a pr gets linked to, but still check the body and link to additional issues: see issue625

If it's desirable to limit it further or allowing only one issue, we could fix that.
msg3413 (view) Author: maciej.szulik Date: 2017-10-28.20:01:03
One other option is to give different priorities. For example, if title has bpo-#### we don't look further in the body and assume this is it. But I bet people will complain about that approach as well. I doubt there's a golden middle way we can satisfy all users.
msg3416 (view) Author: berker.peksag Date: 2017-11-09.20:06:05
I agree with Mariatta. We should just look for the PR title. As a fallback, we can check the body if we can't find an issue number in the title.
Date User Action Args
2017-11-09 20:06:05berker.peksagsetnosy: + berker.peksag
messages: + msg3416
2017-10-28 20:01:03maciej.szuliksetmessages: + msg3413
2017-09-08 01:08:18ezio.melottisetnosy: + r.david.murray
messages: + msg3388
2017-09-08 00:30:28ezio.melottisetnosy: + maciej.szulik, ezio.melotti
messages: + msg3387
2017-06-10 02:12:11Mariattasetstatus: unread -> chatting
messages: + msg3362
2017-06-10 02:10:29Mariattacreate