On Fri, Mar 20, 2009 at 17:14, Daniel (ajax) Diniz <ajaksu@gmail.com> wrote:

> Brett C. wrote:
> > The "needs review" and "patch"are outdated thanks to the stage field
> > and should be removed once there are no issues in the tracker with them
> set but
> > not stage.
>
> I find 'test needed' + 'patch' pretty informative, can't see a way to
> express that based on stages only.

The way I have always viewed it is if a test is needed, then a test is
needed regardless of whether there is a patch. And if a test is missing then
the patch is not ready to be reviewed anyway so it isn't quite as big of a
deal that it exists yet. Otherwise the stage field should be trimmed down
such that the need for a unit test, a patch, and doc changes are more
checkboxes/keywords that they are completed than a stage where one of them
needs to be done.

-Brett