Issue7835
Created on 2010-02-02 00:57 by Jesse.Aldridge, last changed 2010-02-11 02:17 by r.david.murray.
|
|
msg98703 - (view) |
Author: Jesse Aldridge (Jesse.Aldridge) |
Date: 2010-02-02 00:57 |
|
http://stackoverflow.com/questions/2180946/really-weird-issue-with-shelve-python
|
|
msg98704 - (view) |
Author: Jesse Aldridge (Jesse.Aldridge) |
Date: 2010-02-02 01:03 |
|
I ran into an error while trying to use the shelve module. Alex Martelli seemed to think I was running into a python bug. He suggested I file a bug report. For more info see: http://stackoverflow.com/questions/2180946/really-weird-issue-with-shelve-python
|
|
msg98708 - (view) |
Author: R. David Murray (r.david.murray) * |
Date: 2010-02-02 02:52 |
|
Here's a patch that fixes the problem for shelve. For the more general problem with Python shutdown and module cleanup, see issue 812369.
I can come up with a sort-of unit test for this (setting _ClosedDict to None, calling close to prove it doesn't generate an error, and restoring _CloseDict), but it is rather artificial, since the real bug involves __del__ getting called during shutdown after module finalization. So I'm not sure the unit test is worthwhile.
|
|
msg98986 - (view) |
Author: Georg Brandl (georg.brandl) |
Date: 2010-02-07 09:36 |
|
I'd say go ahead and commit without test.
|
|
msg99185 - (view) |
Author: R. David Murray (r.david.murray) * |
Date: 2010-02-11 00:29 |
|
Committed in r78137 to trunk, r78138 py26, r78139 py3k, and r78140 py31.
|
|
msg99191 - (view) |
Author: R. David Murray (r.david.murray) * |
Date: 2010-02-11 02:17 |
|
Fix modified to catch the case where the shutdown has also deleted module dictionary, at MAL's suggestion, in r78142.
|
|
| Date |
User |
Action |
Args |
| 2010-02-11 02:17:30 | r.david.murray | set | messages:
+ msg99191 |
| 2010-02-11 00:29:52 | r.david.murray | set | status: open -> closed
messages:
+ msg99185
components:
+ Library (Lib), - Interpreter Core
resolution: fixed
stage: patch review -> committed/rejected |
| 2010-02-07 09:36:28 | georg.brandl | set | nosy:
+ georg.brandl
messages:
+ msg98986
|
| 2010-02-02 02:52:07 | r.david.murray | set | files:
+ shelve-clean-shutdown.patch
nosy:
+ r.david.murray
versions:
+ Python 3.1, Python 2.7, Python 3.2
messages:
+ msg98708
priority: normal
keywords:
+ easy, patch
stage: patch review |
| 2010-02-02 01:03:06 | Jesse.Aldridge | set | messages:
+ msg98704 |
| 2010-02-02 00:57:45 | Jesse.Aldridge | create | |
|
